Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-1165: Add support for update-related parameters in site install command. #153

Open
wants to merge 12 commits into
base: 2.x
Choose a base branch
from

Conversation

sergepavle
Copy link
Member

@sergepavle sergepavle commented Jul 22, 2021

No description provided.

22Alexandra
22Alexandra previously approved these changes Jul 27, 2021
22Alexandra
22Alexandra previously approved these changes Jul 28, 2021
config/runner.yml Outdated Show resolved Hide resolved
config/runner.yml Outdated Show resolved Hide resolved
nagyad
nagyad previously approved these changes Jul 30, 2021
22Alexandra
22Alexandra previously approved these changes Jul 30, 2021
@sergepavle sergepavle dismissed stale reviews from 22Alexandra and nagyad via c596750 August 2, 2021 12:55
22Alexandra
22Alexandra previously approved these changes Aug 3, 2021
src/Tasks/Drush/Drush.php Outdated Show resolved Hide resolved
config/runner.yml Outdated Show resolved Hide resolved
src/Commands/AbstractDrupalCommands.php Outdated Show resolved Hide resolved
src/Tasks/Drush/Drush.php Outdated Show resolved Hide resolved
@sergepavle sergepavle force-pushed the EWPP-1165 branch 4 times, most recently from 7ac6db6 to 269b4b4 Compare October 26, 2021 11:31
composer.json Outdated
@@ -34,6 +35,9 @@
"composer-exit-on-patch-failure": true
},
"bin": ["bin/run"],
"_readme": [
"We need to use the 1.x version of grasmash/expander so that null values are treated the same way they were treated until release 2.0.0-alpha2 ."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs to be changed/removed

@@ -11,7 +11,8 @@
"consolidation/robo": "^4.0",
"gitonomy/gitlib": "^1.0",
"jakeasmith/http_build_url": "^1.0.1",
"nuvoleweb/robo-config": "^3.0.0"
"nuvoleweb/robo-config": "^3.0.0",
"grasmash/expander": ">=3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudln't we just ^3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants