Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded kubeseal from findRelease #936

Closed
wants to merge 1 commit into from

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Sep 25, 2022

Signed-off-by: Richard Gee richard@technologee.co.uk

Description

Removes the hardcoded reference to kubeseal in favour of using the provided url instead.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Richard Gee <richard@technologee.co.uk>
@rgee0 rgee0 changed the title WIP: Remove hardcoded kubeseal from findRelease Remove hardcoded kubeseal from findRelease Sep 25, 2022
@rgee0
Copy link
Contributor Author

rgee0 commented Sep 25, 2022

Removed WIP

@alexellis
Copy link
Member

Sorry I missed this Richard. I've gone in a slightly different direction and removed the cloud command completely: b61b51e

@alexellis alexellis closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findRelease() assumes usage is only for kubeseal
2 participants