Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with sdk-generator changes and fix batch check consistency #131

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Oct 8, 2024

Description

Updates with changes from the sdk-generator repo, and also fixes an issue where batch check was not correctly setting the consistency option on each individual check.

References

openfga/sdk-generator#428
openfga/sdk-generator#424
openfga/sdk-generator#422

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner October 8, 2024 16:51
@ewanharris ewanharris marked this pull request as draft October 8, 2024 16:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.46%. Comparing base (bd503a9) to head (a328573).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   25.45%   25.46%   +0.01%     
==========================================
  Files         102      102              
  Lines       10576    10578       +2     
==========================================
+ Hits         2692     2694       +2     
  Misses       7612     7612              
  Partials      272      272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris marked this pull request as ready for review October 9, 2024 09:41
@ewanharris ewanharris requested review from a team as code owners October 9, 2024 09:41
@ewanharris ewanharris changed the title refactor: construct params in a way to satisfy generation Update with sdk-generator changes and fix batch check consistency Oct 9, 2024
@ewanharris ewanharris added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit a19a204 Oct 10, 2024
9 checks passed
@ewanharris ewanharris deleted the chore/sdk-generator-update branch October 10, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants