fix: remove reduntant & incorrect helm test #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed incorrect and redundant helm test, which does not verify correct runtime behavior of the deployment.
Description
A helm test should verify that the deployed app responds correctly. The helm test covers basic Kubernetes functionality instead.
Additionally it pulls in busybox when not really needed to the deployment when running
helm test.What problem is being solved?
Break dependency to
busybox:latestHow is it being solved?
Break dependency to busybox:latest.
Review Checklist
mainSummary by CodeRabbit