feat: add option to specify the clusterIP of OpenFGA service #264
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,14 +10,17 @@ metadata: | |
| {{- end }} | ||
| spec: | ||
| type: {{ .Values.service.type }} | ||
| {{- if .Values.service.clusterIP }} | ||
| clusterIP: {{ .Values.service.clusterIP }} | ||
| {{- end }} | ||
|
Comment on lines
+13
to
+15
There was a problem hiding this comment. The new clusterIP field should be documented in the values.schema.json file to provide schema validation and documentation for users. Add a schema definition for the
Member
There was a problem hiding this comment. @Khayet I agree with the bot here, it would be nice to add this to values.schema.json so that it is more visible to users - would you mind doing that? |
||
| ports: | ||
| - name: grpc | ||
| port: {{ (split ":" .Values.grpc.addr)._1 }} | ||
| targetPort: grpc | ||
| protocol: TCP | ||
|
|
||
| {{- if .Values.http.enabled }} | ||
| - name: http | ||
| port: {{ (split ":" .Values.http.addr)._1 }} | ||
| targetPort: http | ||
| protocol: TCP | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The service template references
.Values.service.clusterIPbut this field has not been added to the values.yaml file. Users will not be able to configure this setting without adding it to the values.yaml file. Add aclusterIPfield under theservicesection in values.yaml with appropriate documentation.