Skip to content

Conversation

@svvac
Copy link

@svvac svvac commented Jan 12, 2026

Description

What problem is being solved?

.Capabilities.KubeVersion.GitVersion is unsupported/undocumented by Helm.

How is it being solved?

Use .Capabilities.KubeVersion.Version instead

What changes are made to solve it?

Updating the charts.

This PR also fixes trivial stylistic issues for coherence, in a separate commit. Feel free to ignore.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
    • n/a
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected
    • No test harness for Helm chart

Summary by CodeRabbit

  • Chores
    • Updated Kubernetes version compatibility checks in Helm ingress template configuration
    • Minor formatting adjustments across deployment and job templates

✏️ Tip: You can customize this high-level summary in your review settings.

@svvac svvac requested review from a team as code owners January 12, 2026 10:58
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 12, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes modify OpenFGA Helm chart templates with whitespace formatting adjustments in deployment and job templates, and update version field references from GitVersion to Version in the ingress template for Kubernetes version comparisons.

Changes

Cohort / File(s) Summary
Whitespace formatting in deployment and job templates
charts/openfga/templates/deployment.yaml, charts/openfga/templates/job.yaml
Added trailing spaces to Helm template expressions ({{, }}), including replicas expression, toYaml filters, and end block statements. Purely cosmetic changes with no functional impact.
Version field references in ingress template
charts/openfga/templates/ingress.yaml
Replaced GitVersion with Version in Kubernetes version checks affecting semverCompare conditions, apiVersion selection, ingressClassName handling, pathType, and backend service logic. Minor whitespace adjustment in ingress annotations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change: replacing GitVersion with Version in Helm templates to use documented Kubernetes version fields.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@svvac svvac force-pushed the fix/kube-git-version-deprecation branch from c8bac05 to f038de0 Compare January 12, 2026 11:00
@svvac svvac force-pushed the fix/kube-git-version-deprecation branch from f038de0 to 534bba9 Compare January 12, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant