fix(otel): OPENFGA_TRACE_OTLP_TLS_ENABLED boolean flag quote #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
OPENFGA_TRACE_OTLP_TLS_ENABLEDenvironment variable is correctly handled as a boolean string within the Helm chart templates.Description
What problem is being solved?
In the current Helm chart, the
OPENFGA_TRACE_OTLP_TLS_ENABLEDvariable—used to toggle TLS for OpenTelemetry Protocol (OTLP) tracing—was not being correctly processed. In Kubernetes manifests, environment variable values must be strings. If a boolean (true/false) is passed directly from Helm'svalues.yamlwithout explicit casting or quoting, it causes template rendering errors or be misinterpreted by the OpenFGA server at runtime.How is it being solved?
The issue is resolved by updating the deployment template to ensure that the value of
OPENFGA_TRACE_OTLP_TLS_ENABLEDis explicitly converted to a string (quoted) before being injected into the container environment. This ensures compatibility with Kubernetes API expectations and OpenFGA's configuration logic.What changes are made to solve it?
templates/deployment.yamlto include theOPENFGA_TRACE_OTLP_TLS_ENABLEDenvironment variable.Applied thesurround the value with double quotes to ensure boolean inputs fromquotefunctionvalues.yamlare rendered as"true"or"false".References
Review Checklist
I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev)mainI have added tests to validate that the change in functionality is working as expectedNo test coverageNext Step: Would you like me to help you draft a specific comment for the maintainers or analyze the related CI/CD failures if there are any?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.