Skip to content

Conversation

@yannchabed
Copy link

@yannchabed yannchabed commented Jan 27, 2026

This PR ensures that the OPENFGA_TRACE_OTLP_TLS_ENABLED environment variable is correctly handled as a boolean string within the Helm chart templates.

Description

What problem is being solved?

In the current Helm chart, the OPENFGA_TRACE_OTLP_TLS_ENABLED variable—used to toggle TLS for OpenTelemetry Protocol (OTLP) tracing—was not being correctly processed. In Kubernetes manifests, environment variable values must be strings. If a boolean (true/false) is passed directly from Helm's values.yaml without explicit casting or quoting, it causes template rendering errors or be misinterpreted by the OpenFGA server at runtime.

How is it being solved?

The issue is resolved by updating the deployment template to ensure that the value of OPENFGA_TRACE_OTLP_TLS_ENABLED is explicitly converted to a string (quoted) before being injected into the container environment. This ensures compatibility with Kubernetes API expectations and OpenFGA's configuration logic.

What changes are made to solve it?

  • Updated templates/deployment.yaml to include the OPENFGA_TRACE_OTLP_TLS_ENABLED environment variable.
  • Applied the quote function surround the value with double quotes to ensure boolean inputs from values.yaml are rendered as "true" or "false".
  • Aligned the OTLP TLS configuration with the standard environment variable patterns used elsewhere in the chart.

References

Review Checklist


Next Step: Would you like me to help you draft a specific comment for the maintainers or analyze the related CI/CD failures if there are any?

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration formatting for improved consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

The OpenFGA Helm chart deployment template was updated to change the OPENFGA_TRACE_OTLP_TLS_ENABLED environment variable from an unquoted YAML value to a quoted string literal, ensuring proper YAML formatting.

Changes

Cohort / File(s) Summary
OpenFGA Deployment Configuration
charts/openfga/templates/deployment.yaml
Changed OPENFGA_TRACE_OTLP_TLS_ENABLED environment variable value to quoted string format for YAML compliance

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: quoting a boolean flag for OPENFGA_TRACE_OTLP_TLS_ENABLED in the context of OpenTelemetry configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannchabed
Copy link
Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yannchabed yannchabed marked this pull request as ready for review January 27, 2026 08:23
@yannchabed yannchabed requested review from a team as code owners January 27, 2026 08:23
@yannchabed
Copy link
Author

cc @rhamzeh as a regular contributor WDYT?
This is a very small update. But necessary for a clean OTEL deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants