Skip to content

Conversation

@jdiegosierra
Copy link

@jdiegosierra jdiegosierra commented Feb 3, 2026

Summary

This PR enables Helm template rendering in extraVolumes and extraVolumeMounts fields by replacing toYaml with common.tplvalues.render. This allows users to reference dynamic values like {{ .Release.Namespace }} or {{ .Release.Name }} in volume configurations.

Changes

  • deployment.yaml: Updated extraVolumes, extraVolumeMounts, and migrate.extraVolumeMounts to use common.tplvalues.render
  • job.yaml: Updated migrate.extraVolumes and migrate.extraVolumeMounts to use common.tplvalues.render

Motivation

This change maintains consistency with other template fields in the chart that already use common.tplvalues.render (e.g., sidecars, probes). It provides users with more flexibility when configuring volumes, especially in multi-tenant or multi-namespace scenarios.

Example Usage

After this change, users can now use templates in their values:

```yaml
extraVolumes:

  • name: my-config
    configMap:
    name: my-config-{{ .Release.Namespace }}

extraVolumeMounts:

  • name: my-config
    mountPath: /etc/config/{{ .Release.Name }}
    ```

Testing

  • Changes follow Conventional Commits specification
  • Updated both deployment and migration job templates
  • Maintains backward compatibility (existing static values work unchanged)
  • Uses existing common.tplvalues.render helper from Bitnami common chart dependency

The change is non-breaking as static values will continue to work as before, while now also supporting template evaluation.

Summary by CodeRabbit

  • Refactor
    • Updated template rendering logic to use a generic renderer helper for improved maintainability. Functional behavior remains unchanged.

@jdiegosierra jdiegosierra requested review from a team as code owners February 3, 2026 16:48
Copilot AI review requested due to automatic review settings February 3, 2026 16:48
@jdiegosierra jdiegosierra requested a review from a team as a code owner February 3, 2026 16:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 3, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jdiegosierra / name: Diego (f47b2f0)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances Helm chart flexibility by enabling template rendering in volume configuration fields. Instead of using static YAML rendering with toYaml, the chart now uses common.tplvalues.render to allow dynamic template evaluation in extraVolumes and extraVolumeMounts.

Changes:

  • Replace toYaml with common.tplvalues.render for extraVolumes and extraVolumeMounts in deployment and migration job templates
  • Enable users to use Helm template expressions (e.g., {{ .Release.Namespace }}) in volume configurations
  • Maintain backward compatibility with existing static configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
charts/openfga/templates/deployment.yaml Updated extraVolumes and extraVolumeMounts (including migrate.extraVolumeMounts) to use template rendering
charts/openfga/templates/job.yaml Updated migrate.extraVolumes and migrate.extraVolumeMounts to use template rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Walkthrough

The changes refactor Helm chart templates to delegate YAML rendering of volumes and volumeMounts to a shared template helper function (common.tplvalues.render) instead of directly rendering values inline. This replaces toYaml with the generic renderer while maintaining functional equivalence.

Changes

Cohort / File(s) Summary
Helm Template Rendering Refactoring
charts/openfga/templates/deployment.yaml, charts/openfga/templates/job.yaml
Replaced direct YAML rendering of volumes and volumeMounts with common.tplvalues.render helper, passing value and context parameters. Preserves indentation and output while centralizing rendering logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: enabling template rendering in extraVolumes and extraVolumeMounts fields by switching from toYaml to common.tplvalues.render across deployment and job templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jdiegosierra jdiegosierra force-pushed the feat/template-support-extra-volumes branch from aaa18bf to f5892d7 Compare February 3, 2026 16:52
@jdiegosierra
Copy link
Author

/easycla

…eMounts

Replace toYaml with common.tplvalues.render for extraVolumes and
extraVolumeMounts fields to allow Helm template evaluation within
these values. This enables users to reference dynamic values like
{{ .Release.Namespace }} or {{ .Release.Name }} in volume configurations.

Changes:
- deployment.yaml: Updated extraVolumes, extraVolumeMounts, and migrate.extraVolumeMounts
- job.yaml: Updated migrate.extraVolumes and migrate.extraVolumeMounts

This maintains consistency with other template fields in the chart
that already use common.tplvalues.render (e.g., sidecars, probes).
@jdiegosierra jdiegosierra force-pushed the feat/template-support-extra-volumes branch from f5892d7 to f47b2f0 Compare February 3, 2026 16:53
@jdiegosierra
Copy link
Author

/easycla

@jdiegosierra
Copy link
Author

We are using this chart in https://github.com/maisaai. We would really appreciate it if you could approve the implementation.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants