Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: model client responses #26

Merged
merged 4 commits into from
Oct 11, 2023
Merged

feat: model client responses #26

merged 4 commits into from
Oct 11, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Oct 7, 2023 •
edited
Loading

Description

feat: model client responses

References

Generated by openfga/sdk-generator#218

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@booniepepper booniepepper changed the title feat: model http response data in client responses feat: model client responses Oct 9, 2023
@booniepepper booniepepper force-pushed the feat/model-http-in-client-responses branch from 8fe6bf2 to 68c0d30 Compare October 9, 2023 23:44
@booniepepper booniepepper mentioned this pull request Oct 9, 2023
Merged
4 tasks
@booniepepper booniepepper marked this pull request as ready for review October 9, 2023 23:45
@booniepepper booniepepper requested a review from a team as a code owner October 9, 2023 23:45
@booniepepper booniepepper force-pushed the feat/model-http-in-client-responses branch from 4d3d4a2 to 5d6f617 Compare October 11, 2023 19:13
rhamzeh
rhamzeh previously approved these changes Oct 11, 2023
View reviewed changes
@rhamzeh rhamzeh added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 6cecea0 Oct 11, 2023
16 checks passed
@rhamzeh rhamzeh deleted the feat/model-http-in-client-responses branch October 11, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraible mraible mraible left review comments

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@booniepepper @mraible @rhamzeh