Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync latest from sdk-generator #149

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Sync latest from sdk-generator #149

merged 5 commits into from
Nov 15, 2024

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Nov 15, 2024

Description

This PR updates with the latest on main in sdk-generator that includes updating the openfga/api ref to the version shipped in OpenFGA v1.7.0. It includes the followin

  • Adds support for contextual tuples on the assertions API, needs OpenFGAClient updating to support this which is tracked in Support contextual tuples an assertion in OpenFGAClient sdk-generator#449
  • Changes min/max page size for read api
  • Adds a new response type for 403 responses and changes the existing cancelled response
  • Changes min/max for contextual_tuples
  • Bumps contextual tuples to 100

References

openfga/sdk-generator#448

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@ewanharris ewanharris requested review from a team as code owners November 15, 2024 11:47
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 47.30539% with 88 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (9c3a4b1) to head (47f2016).

Files with missing lines Patch % Lines
openfga_sdk/models/forbidden_response.py 34.92% 41 Missing ⚠️
openfga_sdk/models/auth_error_code.py 44.64% 31 Missing ⚠️
openfga_sdk/models/assertion.py 73.91% 6 Missing ⚠️
openfga_sdk/models/list_users_request.py 50.00% 3 Missing ⚠️
openfga_sdk/models/read_request.py 50.00% 2 Missing ⚠️
openfga_sdk/models/contextual_tuple_keys.py 50.00% 1 Missing ⚠️
openfga_sdk/models/write_assertions_request.py 50.00% 1 Missing ⚠️
...ga_sdk/models/write_authorization_model_request.py 50.00% 1 Missing ⚠️
openfga_sdk/models/write_request_deletes.py 50.00% 1 Missing ⚠️
openfga_sdk/models/write_request_writes.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   69.15%   68.77%   -0.39%     
==========================================
  Files         122      124       +2     
  Lines        9751     9914     +163     
==========================================
+ Hits         6743     6818      +75     
- Misses       3008     3096      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 041a713 Nov 15, 2024
17 checks passed
@ewanharris ewanharris deleted the chore/update-api-ref branch November 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants