Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go-sdk): OpenFgaClient should satisfy SdkClient interface #144

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

adriantam
Copy link
Member

Description

OpenFgaClient did not satisfy SdkClient interface as there are discrepancy in ReadAuthorizationModel and ReadLatestAuthorizationModel method

References

Close openfga/go-sdk#34
Corresponding go-sdk changes openfga/go-sdk#35

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner June 27, 2023 16:34
@adriantam adriantam changed the title fix: OpenFgaClient should satisfy SdkClient interface fix(go-sdk): OpenFgaClient should satisfy SdkClient interface Jun 27, 2023
@adriantam adriantam merged commit 3fd9111 into main Jun 27, 2023
5 checks passed
@adriantam adriantam deleted the fix/OpenFgaInterface branch June 27, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewSdkClient should return SdkClient interface
2 participants