Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go-sdk): miss path where we validate ulid #147

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix(go-sdk): miss path where we validate ulid #147

merged 1 commit into from
Jul 10, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Jul 6, 2023 •
edited
Loading

Description

For Go-SDK, there is a path where we do not allow empty ulid

References

Follow up on #145

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner July 6, 2023 19:22
@adriantam adriantam merged commit dd9a1c9 into main Jul 10, 2023
@adriantam adriantam deleted the fix/ulid_go branch July 10, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantam @rhamzeh