fix(go-sdk): client option + body not respected #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client not taking in details for option and body in list stores/read changes etc. In addition, read auth model does not check and error when auth model is id string Close openfga/go-sdk#41 Close openfga/go-sdk#42
rhamzeh
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Client not taking in details for option and body in list stores/read changes etc. In addition, read auth model does not check and error when auth model is id string is empty
References
Close openfga/go-sdk#41
Close openfga/go-sdk#42
Corresponding Go SDK changes: openfga/go-sdk#43
Review Checklist
main