Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java): add readme shell #193

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Aug 25, 2023

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh requested a review from a team as a code owner August 25, 2023 22:40
@booniepepper
Copy link
Contributor

FYI there was a weird transient failure in the tests

Run make test-integration-client-java
make build-client sdk_language=java tmpdir=/tmp/tmp.Moetv
cat: ./clients/fga-dotnet-sdk/VERSION.txt: No such file or directory

From https://github.com/openfga/sdk-generator/actions/runs/5981058069/job/16228287916?pr=193

I never saw that before. I re-ran the test and it succeeded

@booniepepper booniepepper merged commit 449aece into feat/java-sdk Aug 28, 2023
6 checks passed
@booniepepper booniepepper deleted the chore/java-sdk-readme-shell branch August 28, 2023 12:43
booniepepper pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants