-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(java): Organize Java package paths #195
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds integration tests for the Java SDK For intermediate commit details, see #160 --------- Co-authored-by: Raghd Hamzeh <raghd.hamzeh@auth0.com>
Closes #169 From #170 * chore(java): Update to JUnit 5 * test(java): Move generated OpenFgaApiTest to a template * test(java): Unit test the Check API, introduce Mockito, update javadocs * test(java): Add unhappy case tests * test(java): Flesh out first test on check * clean(java): Remove lengthy javadoc descriptions in unit tests * test(java): Add HTTP mocks and verifications * test(java): Flesh out all unit tests and mocks * clean(java): Remove now-unused api_test.mustache * clean(java): Only configure tests with jvm-test-suite semantics * clean(java): Re-order tests to follow other test suites and order of https://openfga.dev/api/service * clean(java): Refactor tests for brevity and clarity * test(java): Flesh out write API with writes/deletes * test(java): Flesh out expand test, minor refactors * test(java): Add tests on all 400/404/500s, Update status codes on some create/delete tests
Adds Configuration for the SDK. This also includes a StringUtil utility class, and basic credentials modeling (but not handling yet) Closes #154 Details can be found in #173 * feat(java): Introduce a Configuration class * fix(java): Assert deletion by Store ID instead of name for local dev * fix(java): Update integ tests for Configuration change * misc(java): Minor refactors to Configuration * misc(java): Move Configuration class out of ApiClient * refactor(java): Make interface of Configuration more similar to generated models * feat(java): Add isValid() to Configuration * misc(java): Make an errors package path * docs(java): Note in javadocs that Configuration will take precedence over HttpClient settings * refactor(java): Make Configuration an interface, BasicConfiguration an implementation, other updates * refactor(java): Rename Configuration types * feat(java): Add some Credentials types * refactor(java): Rename Configuration template files with config- prefix * refactor(java): Move isNullOrWhitespace out of Configuration * feat(java): Add assertValid() to ClientCredentials * misc(java): Update filenames of "util" classes * Update config/clients/java/template/config-Configuration.java.mustache * Co-authored-by: Raghd Hamzeh <raghd.hamzeh@auth0.com> * Update config/clients/java/template/config-Configuration.java.mustache * Co-authored-by: Raghd Hamzeh <raghd.hamzeh@auth0.com> * feat(java): Add default for API URL when its null/empty/whitespace --------- Co-authored-by: Raghd Hamzeh <raghd.hamzeh@auth0.com>
* refactor(java): Thread Configuration through request builders * refactor(java): Thread Configuration through requests * feat(java): Introduce ConfigurationOverride class * test(java): Add tests on ConfigurationOverride * refactor(java): Consistent code in Configuration.override(...)
- Add Java 20 to CI - Use exact hashes for CI actions - Fix broken link for models in README - Fix artifact version in build.gradle and elsewhere - Git ignore some files --------- Co-authored-by: Raghd Hamzeh <raghd.hamzeh@auth0.com>
* refactor(java): Remove all @generated annotations * refactor(java): Remove unused JSON.java * refactor(java): Move configuration types to dev.openfga.sdk.api.configuration
booniepepper
force-pushed
the
refactor/java-sdk-cleanup-2
branch
from
August 30, 2023 14:57
8b9ad54
to
a98253d
Compare
4 tasks
booniepepper
force-pushed
the
feat/java-sdk
branch
from
September 6, 2023 11:12
3547c9c
to
695a622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Generated version: openfga/java-sdk#10
Review Checklist
main