fix(java-sdk): fix integration test failure for write_and_expand #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booniepepper
force-pushed
the
feat-java/fix-client-tests
branch
10 times, most recently
from
88f9ab5
to
ab673ef
Compare
booniepepper
force-pushed
the
feat-java/fix-client-tests
branch
from
ab673ef
to
e19c48a
Compare
|
The previous error can be seen in this previous test run with test error logging enabled: https://github.com/openfga/sdk-generator/actions/runs/6593409638/job/17915830601#step:7:612 The real response from a docker openfga server contained an extra space. |
|
I'm planning for now to just update the expand integration test case. I suspect the new whitespace is unintentional and other tests don't need the same update |
4 tasks
rhamzeh
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ci: adds error logging for tests
fix: makes an expand integration test tolerate whitespace
References
Generates: openfga/java-sdk#29
Review Checklist
main