Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dotnet): allow case with empty read body #234

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(dotnet): allow case with empty read body #234

merged 1 commit into from
Nov 15, 2023

Conversation

adriantam
Copy link
Member

Description

Do not serialize default value. As such, if read request is provided without any body, it will not serialize tuple_key field.

References

Close openfga/dotnet-sdk#31

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner November 15, 2023 05:26
@rhamzeh rhamzeh added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit e05cfb1 Nov 15, 2023
11 checks passed
@rhamzeh rhamzeh deleted the fix/dotnet_read_all_tuples branch November 15, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to reading all relationship tuples results in an Exception (dotnet)
2 participants
@adriantam @rhamzeh