build(python): fix test command not exiting with an error #438

ewanharris · 2024-10-25T17:10:15Z

Description

make test-client-python doesn't error if the tests error, which isn't really ideal. So, make it error.

~~Unfortunately this PR will fail python CI~~

I have clicked on "allow edits by maintainers".
I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
The correct base branch is being used, if not main
I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

config/clients/python/template/test/credentials_test.py.mustache

evansims

Good catch!

…response difference

build(python): fix test command not exiting with an error

61e539b

ewanharris requested a review from a team as a code owner October 25, 2024 17:10

test(python-sdk): remove test that validates hostname behaviour

373cd9a

ewanharris commented Oct 25, 2024

View reviewed changes

config/clients/python/template/test/credentials_test.py.mustache Show resolved Hide resolved

evansims previously approved these changes Oct 25, 2024

View reviewed changes

ewanharris enabled auto-merge October 25, 2024 17:34

test: remove implicit dependency on request order and instead codify …

ee344ad

…response difference

ewanharris dismissed evansims’s stale review via ee344ad November 4, 2024 12:39

ewanharris requested a review from evansims November 4, 2024 16:55

evansims approved these changes Nov 4, 2024

View reviewed changes

ewanharris added this pull request to the merge queue Nov 4, 2024

Merged via the queue into main with commit d2af985 Nov 4, 2024
14 checks passed

ewanharris deleted the build/test-python-no-error branch November 4, 2024 18:25