Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughA version bump release updating the project version from 0.3.0 to 0.3.1 with corresponding changelog documentation. The changelog entry documents three changes: dependency updates, Gradle action replacement, and gradlew permission restoration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SoulPancake
left a comment
SoulPancake
left a comment
There was a problem hiding this comment.
Oops there a bunch of other files
for reference
https://github.com/openfga/spring-boot-starter/pull/138/changes#diff-fbaffbb33c52ca03f639bf3fce808b31d6fcfcf2fd36b9d3aaaf0f9e2b457f97
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@build.gradle`:
- Line 19: The pom in publish.gradle is hardcoded to '0.3.0' which will override
build.gradle's version; update the pom block in publish.gradle to use the
dynamic project.version instead of the literal string so the published artifact
matches build.gradle's version (refer to the pom { ... version = project.version
} change) and ensure no other hardcoded version strings remain in
publish.gradle.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1d4a0d5c-70c6-4e00-8d2c-61351d7cafe0
📒 Files selected for processing (2)
CHANGELOG.mdbuild.gradle
|
|
||
| group = 'dev.openfga' | ||
| version = '0.3.0' | ||
| version = '0.3.1' |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the hardcoded version in publish.gradle
# Check if publish.gradle contains hardcoded version
rg -n "version = ['\"]0\.3\.0['\"]" publish.gradleRepository: openfga/spring-boot-starter
Length of output: 106
🏁 Script executed:
cat -n publish.gradle | head -25Repository: openfga/spring-boot-starter
Length of output: 1138
🏁 Script executed:
cat -n build.gradle | grep -A 2 -B 2 "version = '0.3.1'"Repository: openfga/spring-boot-starter
Length of output: 154
Critical: Version mismatch will cause incorrect artifact publication.
The hardcoded version in publish.gradle:9 (version = '0.3.0') within the pom block will override the version set in build.gradle (0.3.1), causing the published artifact to carry version 0.3.0 instead of 0.3.1.
The pom block in publish.gradle should reference project.version dynamically:
🔧 Proposed fix for publish.gradle
pom {
group = 'dev.openfga'
name = 'openfga-spring-boot-starter'
version = project.version // Use dynamic version instead of hardcoded '0.3.0'
description = 'This is the Spring Boot Starter for OpenFGA.'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@build.gradle` at line 19, The pom in publish.gradle is hardcoded to '0.3.0'
which will override build.gradle's version; update the pom block in
publish.gradle to use the dynamic project.version instead of the literal string
so the published artifact matches build.gradle's version (refer to the pom { ...
version = project.version } change) and ensure no other hardcoded version
strings remain in publish.gradle.
curfew-marathon
force-pushed
the
release/v0.3.1
branch
from
240d248 to
d7c20dd
Compare
There was a problem hiding this comment.
Pull request overview
This is a release PR for v0.3.1 of the OpenFGA Spring Boot Starter. The PR aims to bump the version from 0.3.0 to 0.3.1 and document the changes since the previous release.
Changes:
- Updated project version from 0.3.0 to 0.3.1 across build files
- Updated example application dependencies to use v0.3.1
- Updated README.md documentation to reference v0.3.1
- Added CHANGELOG.md entry for v0.3.1 documenting three fixes
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated version references from 0.3.0 to 0.3.1 in installation examples |
| build.gradle | Updated root project version to 0.3.1 |
| publish.gradle | Updated published artifact version to 0.3.1 |
| examples/servlet/build.gradle | Updated dependency version to 0.3.1 |
| CHANGELOG.md | Added release notes for v0.3.1 with date 2026-03-31 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - chore: update dependencies | ||
| - fix: replace gradle/wrapper-validation-action with gradle/actions/setup-gradle | ||
| - fix: restore executable permissions to gradlew |
There was a problem hiding this comment.
The PR description lists three changes since v0.3.0: "chore: update dependencies", "fix: replace gradle/wrapper-validation-action with gradle/actions/setup-gradle", and "fix: restore executable permissions to gradlew". However, the provided diffs only show version bumps and CHANGELOG updates. The actual implementation of these changes is not visible in the diffs. Additionally, the current .github/workflows/main.yaml already uses gradle/actions/setup-gradle (not gradle/wrapper-validation-action), suggesting this change may have already been applied in a previous commit or the CHANGELOG entry is inaccurate.
| - chore: update dependencies | ||
| - fix: replace gradle/wrapper-validation-action with gradle/actions/setup-gradle | ||
| - fix: restore executable permissions to gradlew |
There was a problem hiding this comment.
| - chore: update dependencies | |
| - fix: replace gradle/wrapper-validation-action with gradle/actions/setup-gradle | |
| - fix: restore executable permissions to gradlew | |
| - chore: minor ci changes & dependeny updates |
We usually try to avoid mentioning chore in the changelog - Release will still carry them in the details section.
Considering there are no other release notes to speak of, we can mention them, but let's condense them into a single one.
Release v0.3.1
Changes since v0.3.0
gradle/wrapper-validation-actionwithgradle/actions/setup-gradlegradlewRelease checklist
v0.3.1pushed to trigger publish workflowSummary by CodeRabbit