Log who deleted products on current bulk edit products screen

[abdellani]

What? Why?

• Closes Log who deleted products (and other records) #12452

What should we test?

• Delete a product from the admin panel
• Access the logs and check if you can find the following pattern:

"#{self.class} #{id} deleted by #{destroyed_by.id}"

For example

"Product XYZ deleted by USER_ID"

To check the logs, you have two options:

1. use NewRelic, and run a query. For example: "deleted by" (I don't think that's configured on all the servers)
2. Access the server directly and use a command like cat PATH_TO_LOGS | grep "deleted by"

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[dacook]

Hi Mohammed, great to see you! Thanks, yes I think this is good 👍

In my other PR I tried overwriting the destroy method so that you can pass the user_id as a parameter. It's a little cleaner and seems to be fine, but your approach of using standard rails callbacks is probably safer in the long run.

Just a little rubocop issue to fix.

[rioug]

@dacook the issue mention using a separate log file to record product deletion, the solution uses the usual log file are you happy with that ?

[dacook]

Yep, that's ok with me.

• Of course, it means more messages in the one file to sift through when you're debugging. But it could also be beneficial, giving you a bigger picture.
• Also, more messages could mean logs are rotated quicker. But I propose we focus on that separately.

[dacook]

PS this PR uses log level :info, which makes perfect sense.
I just checked and both staging and production environments are currently configured to :info, so this will ensure it is logged 👍

[dacook]

✅ Tested in dev environment:

10:29:43 rails.1   | Spree::Product 13 deleted by 1

I noticed a couple of things:

1. So far this only logs when the user_id is provided. We could enhance it to always log even when the user_id is unknown (eg just "Spree::Product 13 deleted"`). Then it would be super easy to add the module to many models, and would cover all methods of deleting (it doesn't currently cover deleting from the new products_v3 screen).

2. The user_id isn't named, so it's not clear what the number is. It might be helpful to also log the user's name or email. Eg: "Spree::Product 13 deleted by user 1 <example@email.com>"

Maybe something to consider in the next round.

[dacook]

Oops, I just realised @rioug didn't approve yet! Oh well, please comment on the associated issue if you have suggestions for the next step :)

[rioug]

All good, I am happy with the code