-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nagl nbs from skipped notebooks #42
Conversation
This repository caches data generated from notebooks stored in other repositories in the To regenerate the cache for this PR, create a comment on this PR consisting only of the string:
|
/regenerate-cache |
A workflow has been dispatched to regenerate the cookbook cache for this PR.
|
The updated notebooks should need to be in a release on Conda Forge with a tag on GitHub before the cookbook can pick them up |
A workflow dispatched to regenerate the cookbook cache for this PR has just finished.
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt. |
Ah, thanks -- I just made a release with the docs fixes and am adding it to conda now, so hopefully it'll be live by tomorrow. |
/regenerate-cache |
A workflow has been dispatched to regenerate the cookbook cache for this PR.
|
A workflow dispatched to regenerate the cookbook cache for this PR has just finished.
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt. |
Ah... my examples CI is run with OpenEye, which might be why it works in NAGL and not here. Would you consider adding OpenEye to the examples environment @Yoshanuikabundi or should I try to change examples to find a molecule that reliably works with AmberTools? |
Although it looks like it's failing to generate charges for methane?! Edit: ok, that conformer is.... whacky
|
/regenerate-cache |
A workflow has been dispatched to regenerate the cookbook cache for this PR.
|
A workflow dispatched to regenerate the cookbook cache for this PR has just finished.
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt. |
We'd really rather stick to freely available software in the examples environment - it's provided to users as the recommended way to run these notebooks and also used in Colab, and we want to make that process as smooth as possible. Sorry about that! |
Makes sense -- I've removed it from my examples environment and made another release with a bug fix for RDKit. |
/regenerate-cache |
A workflow has been dispatched to regenerate the cookbook cache for this PR.
|
A workflow dispatched to regenerate the cookbook cache for this PR has just finished.
If the workflow was successful, changes will only be visible in the ReadTheDocs preview after it has been rebuilt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for doing this so promptly!
Opening this PR to see if the notebook rendering has been fixed. Related to openforcefield/openff-nagl#92