Skip to content

Update experimental tag #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Update experimental tag #72

merged 5 commits into from
Mar 7, 2025

Conversation

mattwthompson
Copy link
Member

No description provided.

This comment was marked as outdated.

@mattwthompson

This comment was marked as outdated.

1 similar comment
@mattwthompson

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@mattwthompson
Copy link
Member Author

Okay, I need to update the file structure in Interchange for this to work properly

@mattwthompson
Copy link
Member Author

Specifically the examples in the Interchange repo need to be moved around since the directory structure is how "experimental" is determined, i.e. move examples/experimental/openmm-import/ to examples/openmm-import/ or something

@mattwthompson
Copy link
Member Author

@mattwthompson

This comment was marked as outdated.

2 similar comments
@mattwthompson

This comment was marked as outdated.

@mattwthompson

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@mattwthompson mattwthompson marked this pull request as ready for review February 27, 2025 22:52
@Yoshanuikabundi
Copy link
Contributor

I think this now requires a fix in OpenMMForceFields and conflicts with the patch I just merged to pin 0.4.1 - So I think this needs to wait.

@mattwthompson
Copy link
Member Author

Yeah, that's true

@mattwthompson
Copy link
Member Author

This is blocked by openmm/openmmforcefields#365 being in a release, which will probably happen soon

@mattwthompson mattwthompson marked this pull request as draft March 3, 2025 23:02
@mattwthompson

This comment was marked as outdated.

This comment was marked as outdated.

@mattwthompson

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@mattwthompson mattwthompson marked this pull request as ready for review March 6, 2025 02:52
Copy link
Contributor

@Yoshanuikabundi Yoshanuikabundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have checked that the OpenMM import example is correctly marked as non-experimental in the rendered docs.

I should know this but is your preference to merge your own PRs or for the code owner to merge PRs?

@Yoshanuikabundi Yoshanuikabundi removed their assignment Mar 7, 2025
@mattwthompson
Copy link
Member Author

I should know this but is your preference to merge your own PRs or for the code owner to merge PRs?

I'm happy with either - marginal preference towards whatever gets it in quicker but no fuss from me either way 🙂

@mattwthompson mattwthompson merged commit fbb5e5c into main Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants