Fix package data #2127
Open
Fix package data #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
force-pushed
the
fix-package-data
branch
from
cd0ec58 to
3a07345
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
mattwthompson
commented
Dec 2, 2025
| find = {} | ||
| [tool.setuptools.packages.find] | ||
| include = [ 'openff.toolkit*' ] | ||
| exclude = [ 'openff.toolkit.data' ] |
Member
Author
There was a problem hiding this comment.
This prevents files in openff/toolkit/data from being included in Python and Conda packages by default. These files take up the more space the disk than the Python files defining the package itself (this can be turned off):
This may not be desired, and these lines offer control over what is and is not packaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openforcefield/status#122
The key change is that Setuptools crawls for files in
openff/toolkit/instead of the root of the directory (current behavior). This meansdocs.conf.pyis no longer packaged, which it shouldn't be.