Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring full-stack tests back online #77

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Bring full-stack tests back online #77

merged 3 commits into from
Jul 23, 2024

Conversation

mattwthompson
Copy link
Member

The last release of LAMMPS includes a test that lacks a decorator to gracefully skip when it's not installed. Might as well just add it to these tests, though.

@mattwthompson
Copy link
Member Author

@ntBre does this mean anything to you? https://github.com/openforcefield/status/actions/runs/10011341975/job/27817227290#step:11:2300

These failures are

@ntBre
Copy link

ntBre commented Jul 23, 2024

Hmm, yes, that's coming from my tests for the new caching behavior. I added a context manager to temporarily disable the PortalClient's requests.Session field to ensure that the cached data was loaded from the local cache instead of being re-fetched. I see that the root cause is likely a sqlite3.OperationalError: attempt to write a readonly database, which leads me to the qcportal version since 0.55 replaced sqlite3 with apsw. We've been testing against 0.56 in the qcsubmit tests, and only on macos-12. The macos-12 images here are also pulling in 0.56, so I'm guessing something about the M1/0.54 combination is causing problems?

@mattwthompson
Copy link
Member Author

I have two ideas here

  1. Just downpin to some version(s) of things that work (0.54 across the board for QCArchive things, and some comptaible QCSubmit?). This pushes the problem down the road, which might be a value add if there is a genuine issue here
  2. Add a lower constraint to keep tests running along. (Probably something like %s/~=0.50/~=0.56/ here). I prefer this if it works, but don't know that it will

@mattwthompson mattwthompson changed the title Add GROMACS and LAMMPS Bring full-stack tests back online Jul 23, 2024
Comment on lines 27 to 32
- qcportal ~=0.50
- qcportal ~=0.56
- qcengine
- xtb-python
- geometric =1

- openff-qcsubmit ~=0.50
- openff-qcsubmit ~=0.52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about QCPortal/QCSubmit compatibility in these version ranges, this is just the most recent release

@mattwthompson
Copy link
Member Author

Okay, so qcportal >=0.55 doesn't work on M1 at all, but I'd like to avoid downpins. For now I think we should skip QCSubmit on M1 (only). This allows us to keep most M1 tests online without dropping QCSubmit on Intel hardware

@mattwthompson mattwthompson marked this pull request as ready for review July 23, 2024 19:01
@j-wags
Copy link
Member

j-wags commented Jul 23, 2024

(to shortcut my search when I come back here in the future) Matt's opened an issue about the lack of availability of ARM builds for QCFractal here

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattwthompson - I agree that using the latest deps and removing M1 macs from the test matrix is the best option here.

@mattwthompson mattwthompson merged commit e645f54 into main Jul 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants