-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring full-stack tests back online #77
Conversation
@ntBre does this mean anything to you? https://github.com/openforcefield/status/actions/runs/10011341975/job/27817227290#step:11:2300 These failures are
|
Hmm, yes, that's coming from my tests for the new caching behavior. I added a context manager to temporarily disable the |
I have two ideas here
|
devtools/conda-envs/full-stack.yaml
Outdated
- qcportal ~=0.50 | ||
- qcportal ~=0.56 | ||
- qcengine | ||
- xtb-python | ||
- geometric =1 | ||
|
||
- openff-qcsubmit ~=0.50 | ||
- openff-qcsubmit ~=0.52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know anything about QCPortal/QCSubmit compatibility in these version ranges, this is just the most recent release
Okay, so |
(to shortcut my search when I come back here in the future) Matt's opened an issue about the lack of availability of ARM builds for QCFractal here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattwthompson - I agree that using the latest deps and removing M1 macs from the test matrix is the best option here.
The last release of LAMMPS includes a test that lacks a decorator to gracefully skip when it's not installed. Might as well just add it to these tests, though.