Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples of measurement type objects does not follow the standard (table C.15) #560

Closed
petergarnaes opened this issue Jun 26, 2024 · 1 comment · Fixed by #577
Closed
Labels
API EDR V1.2 Non-breaking change for Version 1.2

Comments

@petergarnaes
Copy link

As far as I can see in both the released standard and the draft, table C.15 says the field is called duration, but all examples instead names the field period.

The issue applies to:

@PaulVanSchayck
Copy link

We have, for now, used period in the implementation of the measurementType object in edr-pydantic. See this PR: KNMI/edr-pydantic#11

Also note that in some of the other examples (D.5) an invalid value (according to the spec) of "-PT10M/PT0M" is used. The use of this range to PT0M ("now"?) seems (to us) to be unnecessary as the spec already covers this by writing "A negative sign before a duration value (i.e. -PT10M) infers that the time start starts at the specified duration before the time value assigned to the parameter value."

@m-burgoyne m-burgoyne linked a pull request Sep 16, 2024 that will close this issue
@chris-little chris-little added the API EDR V1.2 Non-breaking change for Version 1.2 label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API EDR V1.2 Non-breaking change for Version 1.2
Projects
Development

Successfully merging a pull request may close this issue.

3 participants