Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for v1.2 #577

Merged
merged 19 commits into from
Oct 31, 2024
Merged

Changes for v1.2 #577

merged 19 commits into from
Oct 31, 2024
+2,089 −520

Conversation

m-burgoyne
Copy link
Collaborator

@m-burgoyne m-burgoyne commented Sep 16, 2024 •
edited
Loading

  • Add support for multi location requests
  • Add support for a limit query parameter
  • Add an annex for recommended aggregation method descriptions for measurementType
  • Updates the reference to the CoverageJSON community standard
  • Add paragraph to specify that the OpenAPI documentation served by the server as the definitive definition of the query parameters that the EDR server supports
  • Fix the time response requirement definition
  • Fix duplicate operationids in OpenAPI examples
  • Add support for requesting specific resolutions in the Cube query
  • Fix the measurementType examples
  • Change Annex A and Annex B to be normative
  • Add support to the Z query parameter for open ranges
  • Add missing Custom dimension definitions
  • Correct error in collection bbox definition

This was referenced Sep 16, 2024
Closed
Closed
Closed
@m-burgoyne m-burgoyne added the API EDR V1.2 Non-breaking change for Version 1.2 label Sep 16, 2024
This was linked to issues Sep 16, 2024
Add an annex listing the aggregation methods for measurementType #321
Closed
Support for requesting specific resolution in /cube endpoint #398
Closed
Add support for querying multiple locations in the locations query #414
Closed
add support for optional limit parameter for some query types #455
Closed
Add reference to CoverageJSON Community Standard #479
Closed
Open ranges for 'z' parameter #527
Closed
This was linked to issues Sep 16, 2024
Add paging support to locations query #529
Closed
Examples of measurement type objects does not follow the standard (table C.15) #560
Closed
Declarations of normative and informative sections need fixing in OGC API - EDR v1.2 #565
Closed
Clarification Needed for /locations Endpoint in OGC API - EDR Specification #568
Closed
@chris-little
Copy link
Contributor

@m-burgoyne I suggest we need a more detailed History section, like Features.

chris-little
chris-little approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope the Metanorma changes work out OK.

@chris-little
Copy link
Contributor

@tomkralidis @m-burgoyne The Generate OpenAPI Bundle workflow needs updating for a more current version of Swagger.

@tomkralidis
Copy link
Collaborator

@tomkralidis @m-burgoyne The Generate OpenAPI Bundle workflow needs updating for a more current version of Swagger.

Is there something broken in the current version?

@chris-little
Copy link
Contributor

chris-little commented Oct 2, 2024 •
edited
Loading

@tomkralidis https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/pull/577/checks but they may not matter. Mentions of node.js too. they are warnings rather than failures: warn deprecated @apidevtools/swagger-cli@4.0.4:

@tomkralidis
Copy link
Collaborator

@tomkralidis https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/pull/577/checks but they may not matter. Mentions of node.js too. they are warnings rather than failures: warn deprecated @apidevtools/swagger-cli@4.0.4:

Ah, ok. The node.js warnings are a function of the GitHub Actions. I've updated #581 to fix these warnings.

@chris-little
Copy link
Contributor

EDR API SWG 122 2024-10-03 agreed to merge when last fixes tweaked (Metanorma problems)

This was referenced Oct 15, 2024
Closed
Closed
chris-little
chris-little approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew! Well done @m-burgoyne

dblodgett-usgs
dblodgett-usgs reviewed Oct 17, 2024
View reviewed changes
core/standard/sections/annex_history.adoc
@@ -25,4 +25,5 @@
|2022-05-12 |Master branch|Mark Burgoyne | all | Add missing requirements and tests for data_queries metadata
|2022-06-01 |1.0.1|G.Hobona | all | Final OGC Staff review
|2023-06-30 |1.1|G.Hobona | all | Final OGC Staff review
|2024-09-19 |1.2|Mark Burgoyne| all | Changes for v1.2 (link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/321[#321], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/398[#398], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/414[#414], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/455[#455], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/479[#479] link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/527[#527], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/529[#529], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/560[#560], link:https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/565[#565])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how we want to do history?

dblodgett-usgs
dblodgett-usgs reviewed Oct 17, 2024
View reviewed changes
core/standard/sections/clause_3_references.adoc Outdated
* [[[RFC2616,RFC 2616]]] Fielding, R., Gettys, J., Mogul, J., Frystyk, H., Masinter, L., Leach, P., Berners-Lee, T.: IETF RFC 2616, HTTP/1.1, https://tools.ietf.org/rfc/rfc2616.txt[https://tools.ietf.org/rfc/rfc2616.txt]
* [[[RFC2818,RFC 2818]]] Rescorla, E.: IETF RFC 2818, HTTP Over TLS, https://tools.ietf.org/rfc/rfc2818.txt[https://tools.ietf.org/rfc/rfc2818.txt]
* [[[RFC3339,RFC 3339]]] Klyne, G., Newman, C.: IETF RFC 3339, Date and Time on the Internet: Timestamps, https://tools.ietf.org/rfc/rfc3339.txt[https://tools.ietf.org/rfc/rfc3339.txt]
* [[[RFC3896,RFC 3896]]] Berners-Lee, T., Fielding, R., Masinter, L: IETF RFC 3896, Uniform Resource Identifier (URI): Generic Syntax, https://tools.ietf.org/rfc/rfc3896.txt[https://tools.ietf.org/rfc/rfc3896.txt]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 3986 -- don't ask my how I know.

dblodgett-usgs
dblodgett-usgs approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@dblodgett-usgs dblodgett-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great. The "limit" addition is good. May be worth fixing a couple very minor things I noted.

@chris-little
Copy link
Contributor

Agreed to merge at OGC EDR API SWG 2024-10-31 #123

@chris-little chris-little merged commit af85c84 into master Oct 31, 2024
1 check passed
@chris-little chris-little deleted the changes-for-v1.2 branch October 31, 2024 14:10
@chris-little chris-little mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-little chris-little chris-little approved these changes

@dblodgett-usgs dblodgett-usgs dblodgett-usgs approved these changes

@solson-nws solson-nws Awaiting requested review from solson-nws

@ShaneMill1 ShaneMill1 Awaiting requested review from ShaneMill1

@iandruska-ibl iandruska-ibl Awaiting requested review from iandruska-ibl

@tomkralidis tomkralidis Awaiting requested review from tomkralidis

Assignees
No one assigned
Labels
API EDR V1.2 Non-breaking change for Version 1.2
Projects
None yet
Milestone
No milestone
4 participants
@m-burgoyne @chris-little @tomkralidis @dblodgett-usgs