Rename updateFrequency to samplingInterval #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the description of updateFrequency:
If the unit is about time, then the field name should be interval.
If the field name is about frequency, then the unit should be Hz.
We have two options:
I decide to choose options 1, rename the field name. Let's consider about existed implementations.
If we redefine the unit, the developer of existed implementation will not get any warning from any IDEs and build systems and linters.
But if we rename the field, they will know that no matter from development tools or runtime errors. So I prefer options 1.