Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17 add logos to the plot uob metoffice national centre for atmospheric science #20

Merged
merged 9 commits into from
Aug 15, 2023
Merged

17 add logos to the plot uob metoffice national centre for atmospheric science #20

merged 9 commits into from
Aug 15, 2023

Conversation

SutarPrasad
Copy link
Member

This PR has added logos to all the available plots

@SutarPrasad SutarPrasad linked an issue Aug 1, 2023 that may be closed by this pull request
Add logos to the plot UoB, MetOffice, National Centre for Atmospheric Science #17
Closed
@SutarPrasad SutarPrasad self-assigned this Aug 1, 2023
@gareth-j
Copy link
Contributor

gareth-j commented Aug 7, 2023

For me the tops of the logos are cut off.
Screenshot 2023-08-07 at 18 04 23

@SutarPrasad
Copy link
Member Author

For me the tops of the logos are cut off. Screenshot 2023-08-07 at 18 04 23

Is it after downloading or it's getting rendered like that in the webpage?

@SutarPrasad
Copy link
Member Author

For me the tops of the logos are cut off. Screenshot 2023-08-07 at 18 04 23

Is it after downloading or it's getting rendered like that in the webpage?

I have shifted the positions of logos little bit below than previous. Please give it a go once again @gareth-j

@SutarPrasad
Copy link
Member Author

image

In SAFARI browser. svg logo inside plot is not loading in firefox hence better we go with .png over there

gareth-j
gareth-j requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can we pull out the images list somewhere so it isn't repeated so many times in the code?

@SutarPrasad
Copy link
Member Author

Looks good but can we pull out the images list somewhere so it isn't repeated so many times in the code?

resolved to use of function instead of list of images.

gareth-j
gareth-j approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/util/helpers.js
/**
* Creates an image object for the layout.
*
* @param {string} source - The image source URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the docstring.

@SutarPrasad SutarPrasad merged commit 8ba6500 into main Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gareth-j gareth-j gareth-j approved these changes

Assignees

@gareth-j gareth-j

@SutarPrasad SutarPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logos to the plot UoB, MetOffice, National Centre for Atmospheric Science
2 participants
@SutarPrasad @gareth-j