-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added download plot functionality to pdf #26
added download plot functionality to pdf #26
Conversation
6b88755
to
302df95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few questions.
…-in-variety-of-different-formats-for-plots-only-or-entire-dashboard
…-in-variety-of-different-formats-for-plots-only-or-entire-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we should just be consistent with our use of let
and not mix in var
unless we for some reason need it for a different scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Describe the changes implemented in this PR (Bug fix, feature, docs update, ...)
Added a Blue download logo with the label: pdf to the bottom right of the Plot. This downloads the plot in pdf format.
Please check if the PR fulfils these requirements
Closes Ability to produce high quality downloads in variety of different formats for plots Only or entire dashboard? #24 ("Replace xxxx with the Github issue number")
[Tests added and passed] if fixing a bug or adding a new feature
Documentation and tutorials updated/added
ESLINT passed