Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added download plot functionality to pdf #26

Conversation

SutarPrasad
Copy link
Member

@SutarPrasad SutarPrasad commented Aug 8, 2023

  • Describe the changes implemented in this PR (Bug fix, feature, docs update, ...)
    Added a Blue download logo with the label: pdf to the bottom right of the Plot. This downloads the plot in pdf format.

  • Please check if the PR fulfils these requirements

@SutarPrasad SutarPrasad force-pushed the 24-ability-to-produce-high-quality-downloads-in-variety-of-different-formats-for-plots-only-or-entire-dashboard branch from 6b88755 to 302df95 Compare August 10, 2023 09:18
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few questions.

package.json Outdated Show resolved Hide resolved
src/components/MultiSiteLineChart/MultiSiteLineChart.js Outdated Show resolved Hide resolved
src/components/MultiSiteLineChart/MultiSiteLineChart.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should just be consistent with our use of let and not mix in var unless we for some reason need it for a different scope.

src/components/MultiSiteLineChart/MultiSiteLineChart.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SutarPrasad SutarPrasad merged commit 00d6934 into main Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to produce high quality downloads in variety of different formats for plots Only or entire dashboard?
2 participants