Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the colours for sites and changing the inlets visualisation #7

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

SutarPrasad
Copy link
Member

@SutarPrasad SutarPrasad commented Jul 26, 2023

  • Closes Fix colours for sites, inlets etc #3
    This PR updates the inlet values mentioned in the map to the outlined button view.
    It also deals with giving a fixed set of colours to the lines in the graph and to the sites highlighted on the map.

@SutarPrasad SutarPrasad linked an issue Jul 26, 2023 that may be closed by this pull request
@SutarPrasad
Copy link
Member Author

Understanding the implementation of the shuffled colours is a bit tough. need help understanding that. @gareth-j

@SutarPrasad SutarPrasad added the enhancement New feature or request label Jul 26, 2023
@SutarPrasad
Copy link
Member Author

I was thinking to keep the markers on the map to be of the same colour as they won't correspond to the lines in plot if we don't want them to be random from an array of camp. Something like below, I felt it projecting a standardise colour scheme.
image

@SutarPrasad SutarPrasad marked this pull request as ready for review July 28, 2023 14:35
@SutarPrasad SutarPrasad force-pushed the 3-fix-colours-for-sites-inlets branch from b155c38 to 81264ff Compare July 28, 2023 15:02
@SutarPrasad SutarPrasad force-pushed the 3-fix-colours-for-sites-inlets branch from cfc3072 to a5c77ed Compare July 31, 2023 08:58
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SutarPrasad SutarPrasad merged commit 698b3e9 into main Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix colours for sites, inlets etc
2 participants