Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstrings #155

Merged
merged 52 commits into from
Jul 9, 2024
Merged

Update docstrings #155

merged 52 commits into from
Jul 9, 2024

Conversation

alexdanjou
Copy link
Contributor

@alexdanjou alexdanjou commented Jul 4, 2024 •
edited
Loading

  • Summary of changes

  • Please check if the PR fulfills these requirements

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passing
  • Documentation and tutorials updated/added
  • Added an entry to the CHANGELOG.md file
  • Added any new requirements to requirements.txt

@alexdanjou alexdanjou marked this pull request as draft July 4, 2024 13:13
@alexdanjou alexdanjou marked this pull request as ready for review July 4, 2024 15:34
@alexdanjou alexdanjou marked this pull request as draft July 4, 2024 15:42
@alexdanjou alexdanjou marked this pull request as ready for review July 5, 2024 15:10
alexdanjou and others added 20 commits July 5, 2024 21:01
@alexdanjou @brendan-m-murphy
Update openghg_inversions/basis/algorithms/_weighted.py
3ae6ec4 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/basis/algorithms/_weighted.py
a65ff19 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/basis/algorithms/_weighted.py
6a919f1 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
5883497 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/hbmcmc.py
df4abdb 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
da1ad62 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
d2d2b04 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
eaacc02 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
52b7e20 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/hbmcmc_post_process.py
512aeb2 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/hbmcmc_post_process.py
67befc5 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
fd59efe 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
9f85cbe 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
47fb49a 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
dd4d406 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
5548e33 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
7e27a99 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
7d588bc 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou @brendan-m-murphy
Update openghg_inversions/hbmcmc/inversion_pymc.py
9b8d1d5 
Co-authored-by: Brendan Murphy <git@mellotron.anonaddy.com>
@alexdanjou
Update hbmcmc.py
a2bfeef
@alexdanjou
Copy link
Contributor Author

Thanks for the correction and comment Brendan! I updated the header of hbmcmc.py, hope it is ok now.

@alexdanjou alexdanjou marked this pull request as draft July 8, 2024 11:10
@alexdanjou alexdanjou marked this pull request as ready for review July 8, 2024 11:11
brendan-m-murphy
brendan-m-murphy approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@brendan-m-murphy brendan-m-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I will look into fixing the failing tests with openghg devel. We can merge this now if we like, or wait until the tests are working (but it has nothing to do with your changes)

@alexdanjou alexdanjou merged commit f31c449 into devel Jul 9, 2024
2 of 3 checks passed
@alexdanjou alexdanjou deleted the update_docstrings branch July 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendan-m-murphy brendan-m-murphy brendan-m-murphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexdanjou @brendan-m-murphy