Sanitize attachment filenames before saving so they are acceptable by QFieldCloud #6197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sentry Issue: QFIELDCLOUD-2YD |
suricactus
force-pushed
the
QF-5868-fix_attachment_upload
branch
2 times, most recently
from
0c5364c to
c6dfe7f
Compare
|
🎉 Ta-daaa, freshly created APKs are available for d423855: arm64-android |
suricactus
force-pushed
the
QF-5868-fix_attachment_upload
branch
from
c6dfe7f to
0d86867
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… QFieldCloud QFieldCloud recently added a restriction for file names so they can work on all popular operating systems. However, the attachment naming expressions have no restrictions to what they are going to evaluate. Therefore the new `FileUtils::sanitizeFilePath` function has been added that will convert the disallowed chars into underscores and return an empty string when the file path cannot be fixed, for example when it is too long. If an empty string is returned,then the default naming kicks in to guarantee the filename can be saved and can be uploaded to QFieldCloud.
suricactus
force-pushed
the
QF-5868-fix_attachment_upload
branch
from
d30a86d to
d423855
Compare
|
@nirvn finally ready for a review. |
nirvn
approved these changes
May 1, 2025
|
Let's merge that and get our ~3,000 unstable user to stress test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QFieldCloud recently added a restriction for file names so they can work on all popular operating systems. However, the attachment naming expressions have no restrictions to what they are going to evaluate.
Therefore the new
FileUtils::sanitizeFilePathfunction has been added that will convert the disallowed chars into underscores and return an empty string when the file path cannot be fixed, for example when it is too long.If an empty string is returned,then the default naming kicks in to guarantee the filename can be saved and can be uploaded to QFieldCloud.
QFieldSync config:
Resulting values: