Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change alert for persistence alias functionality #1723

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege requested a review from a team as a code owner February 17, 2025 20:45
@holgerfriedrich
Copy link
Member

Can you please rebase?

AFAIR the CORE alerts come first after a heading ... So it should move upwards a few lines.

Thanks

@@ -162,6 +162,7 @@ ALERT;Pentair Binding: EasyTouch thing has been renamed to more generic Controll
[5.0.0]
ALERT;Guntamatic Binding: The Binding now uses channel groups and the dynamic status channels now have an index prefix to allow multiple channels with the same description. Existing Items will need to be adjusted.
ALERT;MQTT Binding (Home Assistant): Thing types and channel IDs for things created prior to 4.3.0 have been significantly restructured and simplified. Items will need to be re-linked. Delete and re-create your Things to also have a simplified Thing Type ID in your Thing IDs.
ALERT;CORE: Persistence alias functionality has been improved, allowing defining aliases across strategies and filter criteria for a persistence service. Previous persistence configurations using aliases need to be reconfigured.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be helpful to directly add a link to the according documentation page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the adjusted documentation is available online yet. And the link will change with the release.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kaikreuzer kaikreuzer merged commit c6f2749 into openhab:main Feb 18, 2025
2 checks passed
@kaikreuzer kaikreuzer added this to the 5.0 milestone Feb 18, 2025
@mherwege mherwege deleted the persistence_alias branch February 18, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants