Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockly 4.1 doc updates #2201

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Blockly 4.1 doc updates #2201

merged 2 commits into from
Jan 10, 2024

Conversation

stefan-hoehn
Copy link
Contributor

@stefan-hoehn
Blockly 4.1 doc updates
a7065b2 
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit e551dce
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/659aa99b2c94000008567806
😎 Deploy Preview https://deploy-preview-2201--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

florian-h05
florian-h05 suggested changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments and a few notes.

configuration/blockly/rules-blockly-items-things.md Outdated Show resolved Hide resolved
configuration/blockly/rules-blockly-items-things.md Outdated Show resolved Hide resolved
configuration/blockly/rules-blockly-items-things.md Outdated Show resolved Hide resolved
configuration/blockly/rules-blockly-run-and-process.md Outdated Show resolved Hide resolved
configuration/blockly/rules-blockly-standard-ext.md Show resolved Hide resolved
configuration/blockly/rules-blockly-standard-ext.md Show resolved Hide resolved
configuration/blockly/rules-blockly-standard-ext.md Outdated Show resolved Hide resolved
@stefan-hoehn
review updates
e551dce 
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
florian-h05
florian-h05 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing all my comments.
(I somehow cannot mark them as resolved, probably because I have no write access to this repo.)

@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Jan 10, 2024
@stefan-hoehn stefan-hoehn merged commit 40758a2 into openhab:main Jan 10, 2024
5 checks passed
pgfeller pushed a commit to pgfeller/openhab-docs that referenced this pull request Jan 15, 2024
@stefan-hoehn @pgfeller
Blockly 4.1 doc updates (openhab#2201)
7b0d951 
* Blockly 4.1 doc updates

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>

* review updates

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>

---------

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stefan-hoehn @florian-h05