-
-
Couldn't load subscription status.
- Fork 720
Correct that ECMAScript 5.1 is not available by default #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blockly depends on the JS Scripting add-on (since OH 4) so Rules DSL is the only default.
| As you recall from the previous page, one of the four types of conditions are Script Conditions and one of the four types of actions are Script Actions. | ||
| Choosing either of those presents you with a choice of language to use. | ||
| By default there are only three choices: Blockly, ECMAScript, and Rules DSL. | ||
| By default there are only two choices: Blockly and Rules DSL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blockly requires JS Scripting so really Rules DSL is the only default
| See the docs for the chosen language for details on how to write rules in files for that language. | ||
|
|
||
| openHAB comes with three languages by default (Rules DSL, ECMAScript 5.1, and Blockly) and has a number of [automation add-ons](/addons/#automation) to add more. | ||
| openHAB comes with two languages by default (Rules DSL and Blockly) and has a number of [automation add-ons](/addons/#automation) to add more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openHAB comes with one language by default (Rules DSL) and has ...
I wanted to make minimally invasive changes. |
| As you recall from the previous page, one of the four types of conditions are Script Conditions and one of the four types of actions are Script Actions. | ||
| Choosing either of those presents you with a choice of language to use. | ||
| By default there are only three choices: Blockly, ECMAScript, and Rules DSL. | ||
| By default only Rules DSL is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the case, you should also mention that for this tutorial to work, the reader has to install blockly as well and explain or link to a page how this can be achieved.
| See the docs for the chosen language for details on how to write rules in files for that language. | ||
|
|
||
| openHAB comes with three languages by default (Rules DSL, ECMAScript 5.1, and Blockly) and has a number of [automation add-ons](/addons/#automation) to add more. | ||
| openHAB comes one language for automation (Rules DSL) and has a number of [automation add-ons](/addons/#automation) to add more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> openHAB comes with one language ... by default
(it in fact comes with more languages which may just not installed by default)
8b8a774 to
e35c43c
Compare
|
As tutorials/getting_started/rules_introduction.md contains “For this tutorial we will be using Blockly, which requires installing the JavaScript Scripting add-on.”, I do not repeat the same information at tutorials/getting_started/rules_blockly.md . There are in fact ten types of Conditions shown in MainUI, if one clicks on “Show all”. So I have removed the number of available conditions. Likewise, there are nine type of actions (when mqtt is installed), so I have removed the number of available actions. “Script Action” means selecting in the UI “Inline Script”. I have replaced once “Script Action” with “Inline Script”, leaving “Script Action” on other places. |
No description provided.