Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework semantics for openHAB 4.0.0.M5 #88

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jul 21, 2023

They're now a registry and provider infrastructure, like all the other objects. Also, tags are instances of SemanticTag now, instead of simply interfaces that implement Tag.

@ccutrer ccutrer added the bug Something isn't working label Jul 21, 2023
@ccutrer ccutrer force-pushed the semantics-oh-4.0 branch 4 times, most recently from c6c9f42 to b7981c1 Compare July 22, 2023 14:34
They're now a registry and provider infrastructure, like all the
other objects. Also, tags are instances of SemanticTag now, instead
of simply interfaces that implement Tag.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Copy link
Contributor

@jimtng jimtng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SemanticTags.add doesn't exist at all now. It only existed briefly in oh4 earlier then replaced with the provider system so it shouldn't be in ours either.

It doesn't break anything though and we can refactor later.

@ccutrer
Copy link
Contributor Author

ccutrer commented Jul 23, 2023

I know. I left it on purpose. There will likely be some people on some earlier OH 4.0 milestones for some amount of time. We can remove it in a couple months.

@ccutrer ccutrer merged commit 96631f8 into openhab:main Jul 23, 2023
14 of 16 checks passed
@ccutrer ccutrer deleted the semantics-oh-4.0 branch July 23, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants