-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemap Editor: Extend chart period config for ISO8601 #2186
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Job #1277: Bundle Size — 15.81MiB (+0.3%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
Bundle size by type
View job #1277 report View mherwege:sitemap_period_config branch activity |
@lolodomo FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading openhab/openhab-docs#2158, it seems that 2h
, 5D
etc. should still be supported, but the sitemap editor warns when trying to use them. Can you please fix that?
Also please have a look at my comment below, and consider to use the validate
property of the input (see https://framework7.io/vue/inputs#input-properties) to let the user know his input is invalid while typing.
bundles/org.openhab.ui/web/src/components/pagedesigner/sitemap/widget-details.vue
Outdated
Show resolved
Hide resolved
That should still work, and it did in my testing. There is even a testcase covering it (for 4h). It may have been the second (missing) commit. |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
The validate property is now used. I still keep the separate validation as well as the a wrong value could be provided through the editor. |
@florian-h05 Thank you for your feedback. I believe I responded to your remarks. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
FYI I have removed validate-on-blur
.
Fine with me, but I explicitely disabled it because it just gives an error already on typing the first character, even when it is part of a perfectly valid period definition. I didn't like that, especially because there are many valid combinations and checking the regex only makes sense when the input is complete. With |
Adjust sitemap configuration in main UI for recent changes in sitemap chart period configuration, see openhab/openhab-core#3863.