Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile selection when linking a channel to an item #2936

Closed
wants to merge 1 commit into from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Dec 22, 2024

Regression from #2690

Reported here:
https://community.openhab.org/t/enocean-impossible-to-link-a-rockerswitch-channel-with-an-item-in-main-ui-there-is-no-profile-available-for-the-selected-item/160987

When creating a Thing channel link to an item, the profile selection are disabled. This presents two problems:

  • It made linking a trigger channel to an item not possible, because a profile must be selected, but they're disabled.
  • Linking a non-trigger channel to a new item is possible, but selecting a profile is not possible at link creation. The user has to create the link without a profile first, then go back to edit the link in order to assign a profile.

This PR fixes both these problems.

Note this needs to be backported to 4.3.x

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link

relativeci bot commented Dec 22, 2024

#2580 Bundle Size — 10.9MiB (~+0.01%).

6047ecd(current) vs 0ead7b8 main#2579(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2580
     Baseline
#2579
No change  Initial JS 1.92MiB 1.92MiB
No change  Initial CSS 577.83KiB 577.83KiB
Change  Cache Invalidation 18.31% 17.58%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2947 2947
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2580
     Baseline
#2579
Regression  JS 9.11MiB (~+0.01%) 9.11MiB
No change  CSS 866.74KiB 866.74KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:fix-add-linkProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng
Copy link
Contributor Author

jimtng commented Dec 22, 2024

@ssalonen would you mind testing this to see whether the changes in this PR stilll works for #1478 ?

The test JAR can be found here if you don't want to build it yourself:
https://github.com/jimtng/openhab-webui/releases/tag/ui-link-fix-4.3.1-1

@florian-h05
Copy link
Contributor

@jimtng See #2941, this fixes the same issue and a bit more and refactors the code a bit.
I will therefore close your PR in favour of mine.

@ssalonen
Copy link
Contributor

I am unable to test this due to lack of time, sorry

@jimtng jimtng deleted the fix-add-link branch December 23, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants