Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget mixin: Fix JS error when using both trendline & stylesheet #2952

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #1423.

Fixes openhab#1423.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from ghys as a code owner December 28, 2024 14:10
Copy link

relativeci bot commented Dec 28, 2024

#2609 Bundle Size — 10.97MiB (~+0.01%).

f10ec4f(current) vs 802d412 main#2608(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#2609
     Baseline
#2608
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.39KiB 577.39KiB
Change  Cache Invalidation 17.31% 18.03%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2949 2949
No change  Duplicate Modules 154 154
Change  Duplicate Code 1.78%(-0.56%) 1.79%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2609
     Baseline
#2608
Regression  JS 9.18MiB (~+0.01%) 9.18MiB
No change  CSS 866.47KiB 866.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:widget-trendline-sty...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit 1f4673f into openhab:main Dec 28, 2024
6 checks passed
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 28, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 28, 2024
@florian-h05 florian-h05 deleted the widget-trendline-stylesheet-err branch December 28, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript error for oh-label-card with trendItem and stylesheet
1 participant