Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Session Established Event Type #154

Merged
merged 5 commits into from
May 27, 2024
Merged

New Session Established Event Type #154

merged 5 commits into from
May 27, 2024

Conversation

tulshi
Copy link
Contributor

@tulshi tulshi commented Apr 23, 2024

No description provided.

appsdesh
appsdesh reviewed Apr 23, 2024
View reviewed changes
openid-caep-specification-1_0.md Show resolved Hide resolved
openid-caep-specification-1_0.md Show resolved Hide resolved
openid-caep-specification-1_0.md Show resolved Hide resolved
openid-caep-specification-1_0.md Show resolved Hide resolved
FragLegs
FragLegs reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have any way to version the CAEP spec. It is, however, versioned with a 1_0 version tag. Does the addition of new event types require us to update the version? What would updating that version mean?

openid-caep-specification-1_0.md Outdated Show resolved Hide resolved
openid-caep-specification-1_0.md Show resolved Hide resolved
@tulshi tulshi requested a review from a team as a code owner May 11, 2024 00:01
FragLegs
FragLegs approved these changes May 21, 2024
View reviewed changes
openid-caep-specification-1_0.md Show resolved Hide resolved
@tulshi
Copy link
Contributor Author

tulshi commented May 24, 2024

We don't currently have any way to version the CAEP spec. It is, however, versioned with a 1_0 version tag. Does the addition of new event types require us to update the version? What would updating that version mean?

Tim's new proposal would lead us to be able to version each event separately. We can currently refer to the draft numbering for understanding the version number of the CAEP spec.

@tulshi tulshi closed this May 24, 2024
@tulshi tulshi reopened this May 24, 2024
@tulshi tulshi merged commit 86eb59c into main May 27, 2024
4 checks passed
@tulshi tulshi deleted the session-established-event branch May 27, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcappalli timcappalli timcappalli approved these changes

@FragLegs FragLegs FragLegs approved these changes

@appsdesh appsdesh Awaiting requested review from appsdesh

@iamseanodentity iamseanodentity Awaiting requested review from iamseanodentity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tulshi @FragLegs @appsdesh @timcappalli @iamseanodentity