Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Standardize terms and casing, fix some typos #169

Merged
merged 8 commits into from
May 17, 2024
Merged

Editorial: Standardize terms and casing, fix some typos #169

merged 8 commits into from
May 17, 2024

Conversation

jischr
Copy link
Contributor

@jischr jischr commented May 16, 2024

Editorial PR:

  • fixes some typos
  • standardizes Transmitter Configuration information -> Transmitter Configuration Metadata for consistency within the spec
  • consistently capitalize:
    • Transmitter
    • Receiver
    • Event Stream
  • added an example for Delete Stream Response

@jischr jischr requested a review from a team as a code owner May 16, 2024 15:24
FragLegs
FragLegs requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Just a few small comments.

openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
FragLegs
FragLegs approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

tulshi
tulshi reviewed May 17, 2024
View reviewed changes
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
jischr and others added 7 commits May 17, 2024 09:38
@jischr
fix some typos, casing consistency
2a2c916
@jischr @FragLegs
Update openid-sharedsignals-framework-1_0.md
d223f81 
Co-authored-by: Shayne Miel (he/him) <miel.shayne@gmail.com>
@jischr @FragLegs
Update openid-sharedsignals-framework-1_0.md
6b34b9c 
Co-authored-by: Shayne Miel (he/him) <miel.shayne@gmail.com>
@jischr @FragLegs
Update openid-sharedsignals-framework-1_0.md
72d68f1 
Co-authored-by: Shayne Miel (he/him) <miel.shayne@gmail.com>
@jischr @FragLegs
Update openid-sharedsignals-framework-1_0.md
239229f 
Co-authored-by: Shayne Miel (he/him) <miel.shayne@gmail.com>
@jischr @FragLegs
Apply suggestions from code review
9a11428 
Co-authored-by: Shayne Miel (he/him) <miel.shayne@gmail.com>
@jischr
review suggestions
46962d3
@jischr jischr requested a review from tulshi May 17, 2024 20:21
tulshi
tulshi reviewed May 17, 2024
View reviewed changes
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
@tulshi @jischr
A few more places need similar fixing.
445dae5 
Co-authored-by: Jen Schreiber <jeniwiner@gmail.com>
@tulshi tulshi merged commit a3f26b9 into openid:main May 17, 2024
2 checks passed
@jischr jischr deleted the editorial branch August 27, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulshi tulshi tulshi approved these changes

@timcappalli timcappalli timcappalli approved these changes

@FragLegs FragLegs FragLegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jischr @FragLegs @timcappalli @tulshi