Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subject/sub_id in examples. Fix CAEP example #176

Merged
merged 1 commit into from
May 26, 2024

Conversation

FragLegs
Copy link
Contributor

Finishes the work for Issue #37 by updating the remaining examples that were incorrect.

The following examples all needed subject removed from the event, sub_id added to the base SET, or both:

  • subject-ids-ex-simple
  • subject-ids-ex-complex
  • subject-properties-ex
  • subject-custom-type-ex
  • risc-event-subject-example
  • caep-event-properties-example
  • figarrayaud

In addition, caep-event-properties-example did not actually have a valid CAEP event body, so I updated that as well.

@FragLegs FragLegs requested a review from a team as a code owner May 24, 2024 14:55
@FragLegs FragLegs linked an issue May 24, 2024 that may be closed by this pull request
@tulshi tulshi requested a review from timcappalli May 24, 2024 22:44
@FragLegs FragLegs merged commit 9a0efa0 into main May 26, 2024
2 checks passed
@FragLegs FragLegs deleted the 37-rework-the-examples-sections branch May 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework the "examples" sections
3 participants