Add ibuf_add, ibuf_add_buf, ibuf_add_zero and ibuf_data for OpenBSD 7.3. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzbuhl
commented
Sep 4, 2023
| @@ -18,6 +18,8 @@ | |||
|
|
|||
| /* ibuf API functions added to OpenBSD's imsg-buffer.c in June 2023. */ | |||
|
|
|||
| #ifdef HAVE_IMSG_H | |||
There was a problem hiding this comment.
This could also go to compat/CMakeLists.txt:
if(HAVE_IMSG AND (NOT HAVE_IBUF_ADD_BUF OR NOT HAVE_IBUF_ADD_ZERO OR NOT HAVE_IBUF_DATA))
moritzbuhl
commented
Sep 4, 2023
| void *ibuf_reserve(struct ibuf *, size_t); | ||
|
|
||
| int | ||
| ibuf_add(struct ibuf *buf, const void *data, size_t len) |
There was a problem hiding this comment.
Should I wrap ibuf_add in it's own HAVE_IBUF_ADD ifdef?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.