Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytecode remaining stability #237

Draft
wants to merge 6 commits into
base: code-reflection
Choose a base branch
from

Conversation

asotona
Copy link
Member

@asotona asotona commented Sep 20, 2024

Minor stability fixes of BytecodeGenerator and BytecodeLift


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/237/head:pull/237
$ git checkout pull/237

Update a local copy of the PR:
$ git checkout pull/237
$ git pull https://git.openjdk.org/babylon.git pull/237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 237

View PR using the GUI difftool:
$ git pr show -t 237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/237.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant