-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8368831: ResourceParsingClassHierarchyResolver.getClassInfo(ClassDesc) throws unspecified UncheckedIOException #27559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java
Outdated
Show resolved
Hide resolved
…ierarchyImpl.java Co-authored-by: Adam Sotona <10807609+asotona@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
ClassHierarchyResolver provided by users may sporadically run into exceptions due to reasons out of control, such as UncheckedIOException caused by a bad zip header. We should specify that users are allowed to fail their CHR when they encounter a failure when they support a ClassDesc to avoid hiding errors.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27559/head:pull/27559
$ git checkout pull/27559
Update a local copy of the PR:
$ git checkout pull/27559
$ git pull https://git.openjdk.org/jdk.git pull/27559/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27559
View PR using the GUI difftool:
$ git pr show -t 27559
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27559.diff
Using Webrev
Link to Webrev Comment