8347007: --strip-debug removes parameter names included with -parameters

[slowhog]

Since parameters is an opt-in choice, it's more reasonable to consider that's desired information and make strip parameter names an opt-in choice as well.

This PR changes the default behavior of --strip-debug to keep parameter names when it's available. Add opt-in mechanism,
via the strip-java-debug-attributes plugin by using argument --strip-java-debug-attributes=+parameter-names.

The --strip-debug option is a little bit odd, as it's a main option as well as a plugin option to enable the DefaultStripDebugPlugin, which strip native debug information on platform support the feature, and strip java debug information. In this PR, we chose to support only one mechanism to enable strip parameter names, so we would disable the embed StripJavaDebugAttributesPlugin when StripJavaDebugAttributesPlugin is enabled.

The StripParameterNamesTest illustrate and verify parameter names use cases, mainly focus on argument processing and the parameter names. We didn't verify the regular debug info as that's covered by existing test.

-- Update

The latest change removed the support of strip parameter names, as the MethodParameters attribute is considered necessary attribute to fulfill Java Language Spec even though this attribute is considered optional by JVM spec.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request matching fixVersion 26 to be approved (needs to be created)

Issue

• JDK-8347007: --strip-debug removes parameter names included with -parameters (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27566/head:pull/27566
$ git checkout pull/27566

Update a local copy of the PR:
$ git checkout pull/27566
$ git pull https://git.openjdk.org/jdk.git pull/27566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27566

View PR using the GUI difftool:
$ git pr show -t 27566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27566.diff

Using Webrev

Link to Webrev Comment

[slowhog]

/csr

[bridgekeeper]

👋 Welcome back henryjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@slowhog has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@slowhog please create a CSR request for issue JDK-8347007 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@slowhog The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (766dc01e)
• 01: Full - Incremental (8b5a6c12)
• 00: Full (5594617b)

[nlisker]

Is there a documentation change needed on the tool's doc page?

[nlisker]

This method name specifically implies enabling. Maybe "setEnabled..."?

[SirYwell]

I know this is already existing behavior, but removing the attribute doesn't just remove the parameter names but also the parameter flags. This results in the same bug that was fixed by https://bugs.openjdk.org/browse/JDK-8292275 (or for a more compact description, see the CSR https://bugs.openjdk.org/browse/JDK-8292467).

But that should be addressed separately.

[slowhog]

Thank you for bring in this up. Do not support removal of MethodParameters attribute for now. If there is a need to support that, we can add a separate plugin to address optional attributes for JVM.

[slowhog]

/csr remove

[openjdk]

@slowhog usage: /csr [needed|unneeded], requires that the issue the pull request refers to links to an approved CSR request.

[slowhog]

/csr unneeded

[openjdk]

@slowhog only Reviewers can determine that a CSR is not needed.