JDK-8365424 : [macos26] java/awt/Frame/DisposeTest.java fails on macOS 26 #27585
Conversation
|
👋 Welcome back honkar! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@honkar-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| @@ -39,11 +39,13 @@ | |||
| * @bug 4127271 | |||
| * @summary Tests that disposing of a Frame with MenuBar removes all traces | |||
| * of the Frame from the screen. | |||
| * @run main/othervm -Dsun.java2d.uiScale=1 DisposeTest | |||
There was a problem hiding this comment.
Why do you need to set scale factor=1, does the default break something?
There was a problem hiding this comment.
It doesn't break as such but based on my observation a couple of previous tests on windows fail when there is fractional scaling + color comparison at edges. Set the uiScale to 1 to make the test robust.
| for (int x = 0; x < bi.getWidth(); x++) { | ||
| for (int y = 0; y < bi.getHeight(); y++) { | ||
| for (int x = PIXEL_OFFSET; x < bi.getWidth() - PIXEL_OFFSET; x++) { | ||
| for (int y = PIXEL_OFFSET; y < bi.getHeight() - PIXEL_OFFSET; y++) { |
There was a problem hiding this comment.
It might be better to increase the size of the background frame so that its edge does not appear under the tested frame.
There was a problem hiding this comment.
Currently the backroundFrame is 200x200 and testFrame is 100x100. A difference of 100 pixels seems sufficient for this case.
This test fails on macOS 26 due to slight color mismatch at background frame edges. A offset of 4 pixels is added as fix.
CI testing passes on other platforms.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27585/head:pull/27585$ git checkout pull/27585Update a local copy of the PR:
$ git checkout pull/27585$ git pull https://git.openjdk.org/jdk.git pull/27585/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27585View PR using the GUI difftool:
$ git pr show -t 27585Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27585.diff
Using Webrev
Link to Webrev Comment