8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys #27959

azvegint · 2025-10-23T19:43:14Z

The test does not release previously pressed keys, which may cause failures in subsequent tests.

Testing looks good on all platforms.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys (Bug - P4)

Reviewers

Sergey Bylokhov (@mrserb - Reviewer) Review applies to e766a642
Harshitha Onkar (@honkar-jdk - Reviewer) Review applies to e766a642
Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27959/head:pull/27959
$ git checkout pull/27959

Update a local copy of the PR:
$ git checkout pull/27959
$ git pull https://git.openjdk.org/jdk.git pull/27959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27959

View PR using the GUI difftool:
$ git pr show -t 27959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27959.diff

Using Webrev

Link to Webrev Comment

…e previously pressed keys

bridgekeeper · 2025-10-23T19:45:24Z

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-23T19:46:55Z

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys

Reviewed-by: psadhukhan, serb, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

f73e56e: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo
b7a4c9c: 8366240: Improve memory ordering in new CPU Time Profiler
b31bbfc: 8368787: Error reporting: hs_err files should show instructions when referencing code in nmethods
... and 5 more: https://git.openjdk.org/jdk/compare/b2e431a1cb22b78eca396ac1d97e6c272de72aa9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-23T19:47:38Z

@azvegint The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-23T19:51:13Z

Webrevs

01: Full - Incremental (637249bc)
00: Full (e766a642)

honkar-jdk

LGTM

prsadhuk · 2025-10-24T05:33:54Z

test/jdk/javax/swing/JSlider/bug4382876.java

                }
            });
+
            if (upFail) {


upFail and downFail should be volatile

prsadhuk · 2025-10-24T09:26:13Z

test/jdk/javax/swing/JSlider/bug4382876.java

                slider = new JSlider(-1000, -900, -1000);
                slider.setComponentOrientation(ComponentOrientation.LEFT_TO_RIGHT);
                slider.putClientProperty("JSlider.isFilled", Boolean.TRUE);
                f.add(slider, BorderLayout.CENTER);


also shouldn't we add the component i.e, slider first to frame and then make it visible? here it is made visible and then slider is added..

It doesn't matter as we wait long enough, it should work both ways.

it doesnt matter till it start failing in some platform in some circumstances :-)

azvegint · 2025-10-24T09:43:37Z

/integrate

openjdk · 2025-10-24T09:46:01Z

Going to push as commit 470eedb.
Since your change was applied there have been 8 commits pushed to the master branch:

f73e56e: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo
b7a4c9c: 8366240: Improve memory ordering in new CPU Time Profiler
b31bbfc: 8368787: Error reporting: hs_err files should show instructions when referencing code in nmethods
... and 5 more: https://git.openjdk.org/jdk/compare/b2e431a1cb22b78eca396ac1d97e6c272de72aa9...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-24T09:46:12Z

@azvegint Pushed as commit 470eedb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not releas…

e766a64

…e previously pressed keys

openjdk bot added the client client-libs-dev@openjdk.org label Oct 23, 2025

openjdk bot added the rfr Pull request is ready for review label Oct 23, 2025

mrserb approved these changes Oct 23, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2025

honkar-jdk approved these changes Oct 23, 2025

View reviewed changes

prsadhuk reviewed Oct 24, 2025

View reviewed changes

volatile

637249b

openjdk bot removed the ready Pull request is ready to be integrated label Oct 24, 2025

prsadhuk reviewed Oct 24, 2025

View reviewed changes

prsadhuk approved these changes Oct 24, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 24, 2025

openjdk bot closed this Oct 24, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2025

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys #27959

8370511: test/jdk/javax/swing/JSlider/bug4382876.java does not release previously pressed keys #27959

Uh oh!

Conversation

azvegint commented Oct 23, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 23, 2025

Uh oh!

openjdk bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

prsadhuk Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

azvegint Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

azvegint Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

azvegint commented Oct 24, 2025

Uh oh!

openjdk bot commented Oct 24, 2025

Uh oh!

openjdk bot commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

azvegint commented Oct 23, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 23, 2025 •

edited

Loading

openjdk bot commented Oct 23, 2025 •

edited

Loading

mlbridge bot commented Oct 23, 2025 •

edited

Loading