Skip to content

Conversation

@cushon
Copy link
Contributor

@cushon cushon commented Nov 1, 2025

This is a backport of JDK-8354893, which is a follow-up to JDK-8341779.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8354893 needs maintainer approval

Integration blocker

 ⚠️ Dependency #4150 must be integrated first

Issue

  • JDK-8354893: [REDO BACKPORT] javac crashes while adding type annotations to the return type of a constructor (JDK-8320001) (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4151/head:pull/4151
$ git checkout pull/4151

Update a local copy of the PR:
$ git checkout pull/4151
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4151

View PR using the GUI difftool:
$ git pr show -t 4151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4151.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2025

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/4150 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b2225c8c491e9a5f4f6d2ef14338369d681d6110 8354893: [REDO BACKPORT] javac crashes while adding type annotations to the return type of a constructor (JDK-8320001) Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 1, 2025
@cushon cushon marked this pull request as ready for review November 1, 2025 21:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2025

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cushon
Copy link
Contributor Author

cushon commented Nov 30, 2025

/touch

@openjdk
Copy link

openjdk bot commented Nov 30, 2025

@cushon The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant