-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341261: Tests assume UnlockExperimentalVMOptions is disabled by default #1025
base: master
Are you sure you want to change the base?
Conversation
8341261: Tests assume UnlockExperimentalVMOptions is disabled by default Reviewed-by: stefank, mli, ysr
👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into |
@toddjonker This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request I'd like to backport these test updates to fix failures in a Graal-enabled JDK21 distro. |
@toddjonker |
/integrate |
@toddjonker |
Backport of test changes that ease Graal integration.
Unclean due to JDK-8236736 changing notproduct JVM flags to develop flags, removing the test of notproduct options as of jdk23-ga.
For completeness, I've also requested this for jdk23u at openjdk/jdk23u#137
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1025/head:pull/1025
$ git checkout pull/1025
Update a local copy of the PR:
$ git checkout pull/1025
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1025/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1025
View PR using the GUI difftool:
$ git pr show -t 1025
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1025.diff
Webrev
Link to Webrev Comment