Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341261: Tests assume UnlockExperimentalVMOptions is disabled by default #1025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toddjonker
Copy link
Contributor

@toddjonker toddjonker commented Oct 4, 2024

Backport of test changes that ease Graal integration.

Unclean due to JDK-8236736 changing notproduct JVM flags to develop flags, removing the test of notproduct options as of jdk23-ga.

For completeness, I've also requested this for jdk23u at openjdk/jdk23u#137


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8341261 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8341261: Tests assume UnlockExperimentalVMOptions is disabled by default (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1025/head:pull/1025
$ git checkout pull/1025

Update a local copy of the PR:
$ git checkout pull/1025
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1025

View PR using the GUI difftool:
$ git pr show -t 1025

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1025.diff

Webrev

Link to Webrev Comment

8341261: Tests assume UnlockExperimentalVMOptions is disabled by default

Reviewed-by: stefank, mli, ysr
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

👋 Welcome back toddjonker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@toddjonker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341261: Tests assume UnlockExperimentalVMOptions is disabled by default

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1bdd79e7b2086197ab64161e89bbe8cc180f07ed 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 4, 2024
@toddjonker toddjonker marked this pull request as ready for review October 9, 2024 17:58
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@toddjonker
Copy link
Contributor Author

/approval request I'd like to backport these test updates to fix failures in a Graal-enabled JDK21 distro.

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@toddjonker
8341261: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 15, 2024
@toddjonker
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@toddjonker
Your change (at version 94f9101) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

2 participants